Messages in this thread | | | Date | Mon, 30 Mar 2015 08:12:14 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: arizona: Correct type of gpio_defaults |
| |
On Sun, 29 Mar 2015, Charles Keepax wrote:
> gpio_defaults needs to be specified as an unsigned int rather than an > int, because the intention of the DT binding is that all out of range > values for a 16-bit register will cause the defaults to be used, > however, if gpio_defaults is an int then values that are larger than > INT_MAX will become negative numbers and be written out directly to the > hardware. As no where in the code replies on gpio_defaults being an int, > the simplest fix is to just change it to unsigned. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > include/linux/mfd/arizona/pdata.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
> diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h > index 48fe313..1789cb0 100644 > --- a/include/linux/mfd/arizona/pdata.h > +++ b/include/linux/mfd/arizona/pdata.h > @@ -94,7 +94,7 @@ struct arizona_pdata { > int gpio_base; > > /** Pin state for GPIO pins */ > - int gpio_defaults[ARIZONA_MAX_GPIO]; > + unsigned int gpio_defaults[ARIZONA_MAX_GPIO]; > > /** > * Maximum number of channels clocks will be generated for,
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |