Messages in this thread | | | Date | Mon, 30 Mar 2015 08:48:44 +0200 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 01/86] pci: export pci_ids.h |
| |
On Sun, Mar 29, 2015 at 10:40:47PM +0200, Greg KH wrote: > On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote: > > The macros in pci_ids.h are pretty useful for userspace > > using the pci sysfs interface. > > At the moment userspace is forced to duplicate these macros > > (e.g. QEMU does this), it is better to expose them in > > /usr/include/linux/pci_ids.h so everyone can just include > > this header. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > include/linux/pci_ids.h | 2998 +----------------------------------------- > > include/uapi/linux/pci_ids.h | 2997 +++++++++++++++++++++++++++++++++++++++++ > > No, please use the pci ids file from the upstream pci id database > instead.
> We shouldn't be putting these all in one file,
pci.txt says: Please add PCI_VENDOR_ID_xxx for vendors You want to change this policy, and get rid of vendor ids in pci_ids.h completely? Bjorn, what do you think of this?
> and pulling > them out of drivers isn't ok.
This patchset is not pulling any files out of drivers fwiw.
> Userspace shouldn't need to know any of these, use libpci.
Unless I'm mistaken, libpci does not export a header with defines. It has a text file pci.ids, but parsing that when all I want is e.g. locate all intel devices is just too much overhead. No one wants that, so people just duplicate headers.
Standard class IDs are even sillier to duplicate.
> thanks, > > greg k-h
| |