lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/8] mmc: sdhci-st: Add delay management functions for top registers (eMMC).
Hi Maxime,

On Tue, 03 Mar 2015, Maxime Coquelin wrote:
>
> On 02/26/2015 02:10 PM, Peter Griffin wrote:
> >Due to the tight timing constriants in some UHS modes, it is required to have
> s/constriant/constraints/

Will fix.

<snip>
> >+
> >+static inline void st_mmcss_set_static_delay(void __iomem *ioaddr)
> >+{
> >+ if (ioaddr) {
> Maybe you could do:
> if (!ioaddr)
> return;

Yes good idea, I have made that change in V3.
>
> writel_relaxed....
> >+ writel_relaxed(0x0, ioaddr + ST_TOP_MMC_DLY_CTRL);
> >+ writel_relaxed(ST_TOP_MMC_DLY_MAX,
> >+ ioaddr + ST_TOP_MMC_TX_CLK_DLY);
> >+ }
> >+}
> >+
> >+static inline void st_mmcss_set_dll(void __iomem *ioaddr)
> >+{
> >+ if (ioaddr) {
> Ditto

regards,

Peter


\
 
 \ /
  Last update: 2015-03-30 13:01    [W:0.062 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site