lkml.org 
[lkml]   [2015]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel
On 03/27/2015 07:29 AM, Geoff Levand wrote:
> On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
>> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr)
>> setup_mm_for_reboot();
>>
>> cpu_soft_restart(virt_to_phys(cpu_reset),
>> - is_hyp_mode_available(), addr);
>> +#ifdef CONFIG_KEXEC
>> + !in_crash_kexec &&
>> +#endif
>
> Why not define in_crash_kexec without condition on CONFIG_KEXEC, say
> here in process.c and then avoid these preprocessor conditionals.

Well, I thought of that, but as its name suggested, the variable should
be basically part of kdump code.
Moreover, I suspect that some one might reject a whole idea of patch #3.

-Takahiro AKASHI

>> + is_hyp_mode_available(),
>> + addr);
>>
>> /* Should never get here */
>> BUG();
>
>
>


\
 
 \ /
  Last update: 2015-03-30 06:01    [W:0.036 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site