lkml.org 
[lkml]   [2015]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check
On Fri, Mar 27, 2015 at 01:05:08PM -0400, ira.weiny wrote:

> > But it seems redudent, since mcast_add_one will already not add a port that is
> > not IB, so mcast_event_handler is not callable. Something to do with
> > rocee/ib switching?
>
> I'm not sure about this either. This check seems to be necessary only on a
> per-port level. It does seem apparent that one can't go from Eth to IB. What
> happens if you go from IB to Eth on the port?

Hmm... I see a mlx4_change_port_types which ultimately calls
ib_unregister_device, which suggests the port type doesn't change at
runtime (yay)

So maybe these checks really are redundant?

Jason


\
 
 \ /
  Last update: 2015-03-27 19:01    [W:0.225 / U:2.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site