lkml.org 
[lkml]   [2015]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/4] fs, jfs: remove slab object constructor
On Wed, Mar 25, 2015 at 07:37:40PM -0700, David Rientjes wrote:
> That would be true only for
>
> ptr = mempool_alloc(gfp, pool);
> mempool_free(ptr, pool);
>
> and nothing in between, and that's pretty pointless. Typically, callers
> allocate memory, modify it, and then free it. When that happens with
> mempools, and we can't allocate slab because of the gfp context, mempools
> will return elements in the state in which they were freed (modified, not
> as constructed).

The historic slab allocator (Solaris and early Linux) expects objects
to be returned in the same / similar enough form as the constructor
returned it, and the constructor is only called when allocating pages
from the page pool.

I have to admit that I haven't used this feature forever, and I have no idea if
people changed how the allocator works in the meantime.


\
 
 \ /
  Last update: 2015-03-26 08:41    [W:0.055 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site