Messages in this thread | | | Date | Wed, 25 Mar 2015 19:02:41 +0000 | From | Luis Henriques <> | Subject | Re: [PATCH] ftracetest: replace usleep by sleep |
| |
On Wed, Mar 25, 2015 at 02:57:58PM -0400, Steven Rostedt wrote: > On Wed, 25 Mar 2015 17:36:34 +0000 > Luis Henriques <luis.henriques@canonical.com> wrote: > > > 'usleep' seems to be a distro-specific utility and may not be > > available: > > > > [5] event tracing - enable/disable with event level files [FAIL] > > execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > + [ ! -f set_event -o ! -d events/sched ] > > + reset_tracer > > + echo nop > > + do_reset > > + echo > > + clear_trace > > + echo > > + echo sched:sched_switch > > + usleep 1 > > ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found > > > > Replace it with the more standard sleep. > > > > Signed-off-by: Luis Henriques <luis.henriques@canonical.com> > > --- > > tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++--- > > tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++--- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > index 668616d9bb03..abafc0c3605c 100644 > > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > @@ -21,7 +21,7 @@ reset_tracer > > do_reset > > > > echo 'sched:sched_switch' > set_event > > -usleep 1 > > +sleep 0.001 > > We had patches out about this, because sleep 0.001 is not always > supported either. > > I forgot what the final solution was suppose to be. > > -- Steve
Would a 'sleep 1' be acceptable? Do we care about the execution time?
Cheers, -- Luís
| |