lkml.org 
[lkml]   [2015]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: cpuidle: Document the code
On 03/24/2015 07:51 PM, Lorenzo Pieralisi wrote:
> On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote:
>> Add kernel-doc format documentation in the code.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---

[ ... ]

>> + * Returns:
>> + * 0 on success,
>> + * -ENODEV if it fails to find the cpu node in the device tree,
>> + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu,
>> + * -ENOENT if it fails to find a enabled-method property,
>
> Ultra-nit: "an enabled-method"
>
>> + * -ENXIO if the HW reports a failure or a misconfiguration
>
> -ENOMEM is missing.
>
> Apart from these ultraminor changes (and thanks for putting it
> together):
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>

Thanks for review Lorenzo. I fixed the comment and pushed in my tree for
4.1.

-- Daniel

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog



\
 
 \ /
  Last update: 2015-03-25 08:21    [W:0.069 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site