lkml.org 
[lkml]   [2015]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci warnings
On Wed, Mar 25, 2015 at 07:23:52AM +0100, Julia Lawall wrote:
> Please take a look.
>

It is strange why I did not receive it.
The patch is ok.

Signed-off-by: Peter Chen <peter.chen@freescale.com>

> thanks,
> julia
>
> On Wed, 25 Mar 2015, kbuild test robot wrote:
>
> > TO: Peter Chen <peter.chen@freescale.com>
> > CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> > CC: linux-usb@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> >
> > drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297
> >
> >
> > Removes unneeded variable used to store return value.
> >
> > Generated by: scripts/coccinelle/misc/returnvar.cocci
> >
> > CC: Peter Chen <peter.chen@freescale.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > usbmisc_imx.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > --- a/drivers/usb/chipidea/usbmisc_imx.c
> > +++ b/drivers/usb/chipidea/usbmisc_imx.c
> > @@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im
> > unsigned long flags;
> > struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
> > u32 val;
> > - int ret = 0;
> >
> > usbmisc_imx6q_init(data);
> >
> > @@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im
> > spin_unlock_irqrestore(&usbmisc->lock, flags);
> > }
> >
> > - return ret;
> > + return 0;
> > }
> >
> > static int usbmisc_vf610_init(struct imx_usbmisc_data *data)
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--

Best Regards,
Peter Chen


\
 
 \ /
  Last update: 2015-03-25 07:41    [W:0.071 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site