Messages in this thread | | | Date | Wed, 25 Mar 2015 13:25:15 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4 v6] kernel/fork.c: avoid division by zero |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/18, Ingo Molnar wrote: > > > > But ... no strong feelings from me, I'm not NAK-ing it or anything, > > maybe I'd have used this well-known pattern: > > > > threads = min(max(MIN_THREADS, threads), MAX_THREADS); > > > > instead of: > > > > > >> + if (threads > MAX_THREADS) > > > >> + threads = MAX_THREADS; > > > >> + > > > >> + if (threads < MIN_THREADS) > > > >> + threads = MIN_THREADS; > > clamp(threads, MIN_THREADS, MAX_THREADS) > > ;)
Indeed ;-)
Thanks,
Ingo
| |