Messages in this thread | | | Date | Wed, 25 Mar 2015 11:03:27 +0000 | From | Charles Keepax <> | Subject | Re: [alsa-devel] [PATCH] ASoC: DAPM: Fix build warning |
| |
On Wed, Mar 25, 2015 at 11:53:30AM +0100, Takashi Iwai wrote: > At Wed, 25 Mar 2015 10:13:28 +0000, > Charles Keepax wrote: > > > > commit c66150824b8a ("ASoC: dapm: add code to configure dai link > > parameters") introduced the following build warning: > > > > sound/soc/soc-dapm.c: In function 'snd_soc_dapm_new_pcm': > > sound/soc/soc-dapm.c:3389:4: warning: passing argument 1 of 'snprintf' > > discards 'const' qualifier from pointer target type > > snprintf(w_param_text[count], len, > > > > This patch fixes this by adding a non-const temporary variable to hold > > the value as it is created before assigning to the entry in > > w_param_text. > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > > An easier fix would be to replace with devm_kasprintf(). Then you can > do it all in a single line. > > w_param_text[count] = devm_kasprintf(card->dev, GFP_KERNEL, > "Anonymous Configuration %d", count); > > > Takashi
Thanks wasn't aware of that one, I will respin.
Thanks, Charles
| |