lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86()

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Mon, Mar 23, 2015 at 5:26 AM, tip-bot for Andy Lutomirski
> <tipbot@zytor.com> wrote:
> > Commit-ID: a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Gitweb: http://git.kernel.org/tip/a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Author: Andy Lutomirski <luto@kernel.org>
> > AuthorDate: Wed, 18 Mar 2015 18:33:29 -0700
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Mon, 23 Mar 2015 11:13:36 +0100
> >
> > x86/asm/entry: Add user_mode_ignore_vm86()
> >
> > user_mode() is dangerous and user_mode_vm() has a confusing name.
> >
> > Add user_mode_ignore_vm86() (equivalent to current user_mode()).
> > We'll change the small number of legitimate users of user_mode()
> > to user_mode_ignore_vm86().
> >
> > Inspired by grsec, although this works rather differently.
>
> Ingo, does this mean that you changed your mind or do you still want
> a patch to delete user_mode_ignore_vm86 and just use user_mode
> everywhere instead?

Would be still nice to have it as an add on patch, if you agree with
my arguments.

I picked up your series as-is because it's correct and because it
already improves things a lot in this area.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-03-24 21:21    [W:0.174 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site