lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 63/79] ipvs: add missing ip_vs_pe_put in sync code
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Julian Anastasov <ja@ssi.bg>

    commit 528c943f3bb919aef75ab2fff4f00176f09a4019 upstream.

    ip_vs_conn_fill_param_sync() gets in param.pe a module
    reference for persistence engine from __ip_vs_pe_getbyname()
    but forgets to put it. Problem occurs in backup for
    sync protocol v1 (2.6.39).

    Also, pe_data usually comes in sync messages for
    connection templates and ip_vs_conn_new() copies
    the pointer only in this case. Make sure pe_data
    is not leaked if it comes unexpectedly for normal
    connections. Leak can happen only if bogus messages
    are sent to backup server.

    Fixes: fe5e7a1efb66 ("IPVS: Backup, Adding Version 1 receive capability")
    Signed-off-by: Julian Anastasov <ja@ssi.bg>
    Signed-off-by: Simon Horman <horms@verge.net.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/netfilter/ipvs/ip_vs_sync.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/net/netfilter/ipvs/ip_vs_sync.c
    +++ b/net/netfilter/ipvs/ip_vs_sync.c
    @@ -891,6 +891,8 @@ static void ip_vs_proc_conn(struct net *
    IP_VS_DBG(2, "BACKUP, add new conn. failed\n");
    return;
    }
    + if (!(flags & IP_VS_CONN_F_TEMPLATE))
    + kfree(param->pe_data);
    }

    if (opt)
    @@ -1164,6 +1166,7 @@ static inline int ip_vs_proc_sync_conn(s
    (opt_flags & IPVS_OPT_F_SEQ_DATA ? &opt : NULL)
    );
    #endif
    + ip_vs_pe_put(param.pe);
    return 0;
    /* Error exit */
    out:



    \
     
     \ /
      Last update: 2015-03-24 19:21    [W:5.133 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site