Messages in this thread | | | Date | Tue, 24 Mar 2015 09:56:07 +0100 | From | Olaf Hering <> | Subject | Re: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is not chained |
| |
On Mon, Mar 23, K. Y. Srinivasan wrote:
> @@ -653,32 +640,39 @@ static unsigned int copy_from_bounce_buffer(struct scatterlist *orig_sgl, > unsigned long bounce_addr = 0; > unsigned long dest_addr = 0; > unsigned long flags; > + struct scatterlist *cur_dest_sgl; > + struct scatterlist *cur_src_sgl; > > local_irq_save(flags); > - > + cur_dest_sgl = orig_sgl; > + cur_src_sgl = bounce_sgl; > for (i = 0; i < orig_sgl_count; i++) { > - dest_addr = sg_kmap_atomic(orig_sgl,i) + orig_sgl[i].offset; > + dest_addr = (unsigned long) > + kmap_atomic(sg_page(cur_dest_sgl)) + > + cur_dest_sgl->offset; > dest = dest_addr; > destlen = orig_sgl[i].length; > + destlen = cur_dest_sgl->length;
Double assignment.
Olaf
| |