lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rts5208: Fixed 80 char & indent warnings
From
Date
On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct. :(

True. Please run your proposed patches through checkpatch
before sending them.

I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.

It would also reduce the code size quite a bit if the TRACE
portion of TRACE_RET/TRACE_GOTO was a separate function and
not an inline.



\
 
 \ /
  Last update: 2015-03-24 15:21    [W:0.036 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site