Messages in this thread | | | Subject | Re: [PATCH] staging: rts5208: Fixed 80 char & indent warnings | From | Joe Perches <> | Date | Tue, 24 Mar 2015 07:16:36 -0700 |
| |
On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote: > None of these are correct. :(
True. Please run your proposed patches through checkpatch before sending them.
I think it would be an improvement to rework the flow-hiding TRACE_RET and TRACE_GOTO macros into two separate lines.
It would also reduce the code size quite a bit if the TRACE portion of TRACE_RET/TRACE_GOTO was a separate function and not an inline.
| |