lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] IIO: Adds ACPI support for ST gyroscopes
From
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca <robert.dolca@intel.com> wrote:

Oh more comments still...

> + /* Get IRQ GPIO */
> + gpiod_irq = devm_gpiod_get_index(&client->dev, 0, 0);
> + if (IS_ERR(gpiod_irq))
> + return -ENODEV;

Shouldn't that be devm_gpiod_get_index_optional()?

I think the driver is useable also without that GPIO/IRQ
and should not error out. (Will cause bugs in other
platforms!)

Also: maybe the GPIO/IRQ support should be in a separate
patch so as not to confuse with the ACPI stuff.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-03-24 12:01    [W:0.114 / U:27.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site