lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: sm7xxfb: start using module parameters
On Tue, Mar 24, 2015 at 10:48:26AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 24, 2015 at 10:20:08AM +0530, Sudip Mukherjee wrote:
> > + "\t\t0x31B = 1280x1024-24\n"
> > + "\t\tUsual example:\n"
> > + "\t\tinsmod ./sm7xxfb.ko mode_option=\"0x301\"\n");
> > +
>
> That's funny :)
>
> And how do you handle multiple devices in the system?
frankly speaking, never got the idea about multiple devices.

>
> :(
>
> Seriously, never use module parameters for device parameters, they are
> two different things. The framebuffer core has options for handling
> modes, why not use them?
>
> And yes, lots of framebuffer drivers do have crazy module parameters,
> but that doesn't mean you have to perpetuate the insanity, please do
> things properly here.
i am learning from other framebuffer drivers. i guess i should only
see at skeletonfb.c and not the others.
please drop this 1/2 patch, do i need to resend the 2/2 which adds
the MODULE_DEVICE_TABLE ?

regards
sudip

>
> thanks,
>
> greg k-h


\
 
 \ /
  Last update: 2015-03-24 11:41    [W:0.055 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site