lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline
From
Date
On Tue, 2015-02-03 at 12:39 +0100, Christophe Leroy wrote:
> csum_tcpudp_magic() is only a few instructions, and does not modifies any other
> register than the returned result. So it is not worth having it as a separate
> function and suffer function branching and saving of volatile registers.
> This patch makes it inline by use of the already existing csum_tcpudp_nofold()
> function.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> v2: no change
>
> arch/powerpc/include/asm/checksum.h | 15 +++++++++++++++
> arch/powerpc/lib/checksum_32.S | 16 ----------------
> 2 files changed, 15 insertions(+), 16 deletions(-)

The 64-bit version is pretty similar to the 32-bit -- why only use
csum_tcpudp_nofold() on 32-bit?

-Scott




\
 
 \ /
  Last update: 2015-03-25 03:21    [W:0.053 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site