Messages in this thread | | | Subject | Re: [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline | From | Scott Wood <> | Date | Tue, 24 Mar 2015 21:10:04 -0500 |
| |
On Tue, 2015-02-03 at 12:39 +0100, Christophe Leroy wrote: > csum_tcpudp_magic() is only a few instructions, and does not modifies any other > register than the returned result. So it is not worth having it as a separate > function and suffer function branching and saving of volatile registers. > This patch makes it inline by use of the already existing csum_tcpudp_nofold() > function. > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > > --- > v2: no change > > arch/powerpc/include/asm/checksum.h | 15 +++++++++++++++ > arch/powerpc/lib/checksum_32.S | 16 ---------------- > 2 files changed, 15 insertions(+), 16 deletions(-)
The 64-bit version is pretty similar to the 32-bit -- why only use csum_tcpudp_nofold() on 32-bit?
-Scott
| |