Messages in this thread | | | From | Jes Sorensen <> | Subject | Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses | Date | Tue, 24 Mar 2015 20:28:56 -0400 |
| |
Joe Perches <joe@perches.com> writes: > Create an rt_trace function using %pV to reduce overall code size. > Update the macro uses to remove unnecessary and now harmful parentheses. > > Miscellanea around these changes: > > o Coalesce formats > o Realign arguments > o Remove commented-out RT_TRACE uses > o Spelling fixes in formats > o Add missing newlines to formats > o Remove multiple newlines from formats > o Neaten formats where noticed > o Use %pM in one instance > > Reduces code size ~20KB > > Signed-off-by: Joe Perches <joe@perches.com> > --- > Mostly done by various scripts&emacs. > Compiled, untested, no hardware,
This could be further improved by fixing up all the places where the function name is hard coded into the print statement, instead of using __func__. In particular as a lot of it is carried over from old code and has been renamed since.
It's OK with me to do this in a follow-on patch though.
Jes
| |