Messages in this thread | | | Date | Wed, 25 Mar 2015 00:31:51 +0100 | From | Willy Tarreau <> | Subject | Re: [PATCH v3] staging: panel: fix lcd type |
| |
On Tue, Mar 24, 2015 at 04:29:32PM +0530, Sudip Mukherjee wrote: > the lcd type as defined in the Kconfig is not matching in the code. > as a result the rs, rw and en pins were getting interchanged. > Kconfig defines the value of PANEL_LCD to be 1 if we select custom > configuration but in the code LCD_TYPE_CUSTOM is defined as 5. > > my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it > as pins of LCD_TYPE_OLD, and it was not working. > Now values are corrected with referenece to the values defined in > Kconfig and it is working. > checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration. > > Cc: <stable@vger.kernel.org> # 2.6.32+ > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > v3: added the module_parameters > v2: cc-ed stable
Acked-by: Willy Tarreau <w@1wt.eu>
[ next time I'll read my mails in reverse order :-) ]
Willy
| |