Messages in this thread | | | Date | Tue, 24 Mar 2015 19:23:18 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tool: Add event name to error message for filters |
| |
Em Tue, Mar 24, 2015 at 04:00:36PM -0600, David Ahern escreveu: > On 3/24/15 3:57 PM, Arnaldo Carvalho de Melo wrote: > >With the patch below, that leaves printing something, using whatever UI, to the > >tool, acceptable? > > I keep forgetting about the python bindings.
Oh, its not just about the python bindings, but kinda layering violation, i.e. we should leave the error reporting to the actual tool, that may be using GTK, Qt, some custom made TUI, whatever UI.
The python bindings, were not a problem somehow, at least 'perf test python' hasn't failed when I tried.
> Your patch serves the purpose. Thanks, Arnaldo.
Thanks,
Applying with your Acked-by and Based-on-a-patch-by.
- Arnaldo
| |