Messages in this thread | | | Subject | Re: [PATCH 10/11] x86/xip: resolve alternative instructions at build | From | Paul Bolle <> | Date | Mon, 23 Mar 2015 23:40:29 +0100 |
| |
Whitespace nits, mainly, I'm afraid.
On Mon, 2015-03-23 at 00:46 -0700, Jim Kukunas wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig
> +menu "XIP Alternative Instructions" > + depends on XIP_KERNEL > + > + config XIP_ENABLE_X86_FEATURE_POPCNT
No need to indent this line.
> + bool "Enable POPCNT alternative instructions" > + default n > + > + config XIP_ENABLE_X86_BUG_11AP
Ditto.
> + bool "Enable 11AP alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_XMM2
Etc.
> + bool "Enable XMM2 alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_MFENCE_RDTSC > + bool "Enable MFENCE_RDTSC alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_LFENCE_RDTSC > + bool "Enable LFENCE_RDTSC alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_3DNOW > + bool "Enable 3DNOW alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_XMM > + bool "Enabled XMM alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_CLFLUSHOPT > + bool "Enable CLFLUSHOPT alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_XSAVEOPT > + bool "Enable XSAVEOPT alternative instructions" > + default n > + > + config XIP_ENABLE_X86_FEATURE_XSAVES > + bool "Enable XSAVES alternative instructions" > + default n > + > +endmenu > +
The "n defaults are probably unneeded too.
Paul Bolle
| |