Messages in this thread | | | Date | Mon, 23 Mar 2015 12:57:54 +0100 | From | Joerg Roedel <> | Subject | Re: [v4 2/8] iommu, x86: Define new irte structure for VT-d Posted-Interrupts |
| |
Hi Feng,
On Mon, Feb 02, 2015 at 04:06:58PM +0800, Feng Wu wrote: > Add a new irte_pi structure for VT-d Posted-Interrupts. > > Signed-off-by: Feng Wu <feng.wu@intel.com> > Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com> > Acked-by: David Woodhouse <David.Woodhouse@intel.com> > --- > include/linux/dmar.h | 32 ++++++++++++++++++++++++++++++++ > 1 files changed, 32 insertions(+), 0 deletions(-) > > diff --git a/include/linux/dmar.h b/include/linux/dmar.h > index 8473756..c7f9cda 100644 > --- a/include/linux/dmar.h > +++ b/include/linux/dmar.h > @@ -212,6 +212,38 @@ struct irte { > }; > }; > > +struct irte_pi {
I think it is better to put this as a union into struct irte. It saves memory and unnecessary casting in later patches.
Joerg
| |