Messages in this thread | | | Date | Fri, 20 Mar 2015 14:27:40 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start |
| |
Hi Laurent,
On 20/03/15 14:20, Laurent Pinchart wrote: > Hi Sudeep, > > Thank you for the patch. > > On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: >> Commit a124820de5fd ("usb: isp1760: fix possible deadlock in >> isp1760_udc_irq") replaced spin_{un,}lock with >> spin_{un,}lock_irq{save,restore}. However it missed an error path resulting >> in the smatch warning as below: >> >> drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: >> inconsistent returns 'irqsave:flags'. Locked on: line 1207 >> Unlocked on: line 1199 >> >> This patch fixes the spin unlock in the error path in isp1760_udc_start >> thereby removing the smatch warning mentioned above. >> >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Cc: Felipe Balbi <balbi@ti.com> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >
Thanks
>> --- >> drivers/usb/isp1760/isp1760-udc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Hi Laurent, Felipe, >> >> I am extremely sorry for missing this in my original patch. > > I hope you will be ashamed for the 7 generations to come for this totally > unacceptable low quality standard. >
Yes ;)
Regards, Sudeep
| |