Messages in this thread | | | Date | Mon, 2 Mar 2015 22:03:59 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 1/4] usb: phy: twl4030: make runtime pm more reliable. |
| |
Hi!
> + status_changed = > + (twl->linkstat == OMAP_MUSB_VBUS_VALID || > + twl->linkstat == OMAP_MUSB_ID_GROUND) > + != > + (status == OMAP_MUSB_VBUS_VALID || > + status == OMAP_MUSB_ID_GROUND); > twl->linkstat = status; ... > @@ -768,6 +770,10 @@ static int twl4030_usb_remove(struct platform_device *pdev) > > /* disable complete OTG block */ > twl4030_usb_clear_bits(twl, POWER_CTRL, POWER_CTRL_OTG_ENAB); > + > + if (twl->linkstat == OMAP_MUSB_VBUS_VALID || > + twl->linkstat == OMAP_MUSB_ID_GROUND) > + pm_runtime_put_noidle(twl->dev); > pm_runtime_mark_last_busy(twl->dev);
inline function returning (x == OMAP_MUSB_VBUS_VALID || x == OMAP_MUSB_ID_GROUND) would really help readability here.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |