lkml.org 
[lkml]   [2015]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote:
> On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@lip6.fr>
> wrote:
>
> >From: Laure Millet <laure.millet@lip6.fr>
> >
> >This patch fixes lines over 80 characters
>
> I think the newer rule is that strings shouldn't be split across lines.
> That makes
> the first hunk invalid, though the second one is OK.

No, that first hunk is just fine, that horrid DFID macro allows it to
now be split :)

To fix this correctly, you need to move to using the "real" in-kernel
pr_err() functions, not custom macros. When that happens, checkpatch.pl
will stop complaining.

I'll take this one as-is.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-03-18 22:41    [W:0.119 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site