lkml.org 
[lkml]   [2015]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] blkmq: Fix NULL pointer deref when all reserved tags in use

> Good catch! But why not put the hctx == NULL check in as a conditional
> in bt_get() before running the queue? I can't imagine other cases where
> calling blk_mq_run_hw_queue() with hctx == NULL would be a valid scenario.

The change was meant to be broad in scope. A runtime NULL deref is a
rather unfortunate way to determine that there are other invalid scenarios.

But given that both approaches fix the immediate problem, I'd be happy
to change the patch as you suggest.





\
 
 \ /
  Last update: 2015-03-18 22:21    [W:0.054 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site