Messages in this thread Patch in this message | | | Date | Wed, 18 Mar 2015 16:19:35 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v3 -tip] perf tools: fix building error for arm64. |
| |
On Tue, Mar 17, 2015 at 01:29:47PM +0000, Wang Nan wrote: > Commit b11db6581beaccef8ae9a388ae96074aa5cc144f ("perf tools: Fix build > error on ARCH=i386/x86_64/sparc64") uses sed on ARCH, which triggers a > bug in sequence of sed expression, where 's/arm.*/arm/' will replace > 'arm64' to 'arm', causes arm64 building failure. > > This patch prevent 'arm64' to be mached for 'arm.*' case. > > Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> --- > v2 -> v3: > Make the 'arm.*' expression complete according to Jiri Olsa's suggestion. > --- > tools/perf/config/Makefile.arch | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch > index e972057..e11fbd6 100644 > --- a/tools/perf/config/Makefile.arch > +++ b/tools/perf/config/Makefile.arch > @@ -4,7 +4,7 @@ endif > > ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/ \ > -e s/sun4u/sparc/ -e s/sparc64/sparc/ \ > - -e s/arm.*/arm/ -e s/sa110/arm/ \ > + -e /arm64/!s/arm.*/arm/ -e s/sa110/arm/ \ > -e s/s390x/s390/ -e s/parisc64/parisc/ \ > -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \ > -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \ > -- > 1.8.3.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |