Messages in this thread | | | Date | Wed, 18 Mar 2015 17:20:15 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 6/8] rbtree: Implement generic latch_tree |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> Implement a latched RB-tree in order to get unconditional RCU/lockless > lookups.
Two very minor nits:
> +struct latch_tree_node { > + /* > + * Because we have an array of two entries in struct latch_tree_nodes > + * its not possible to use container_of() to get back to the > + * encapsulating structure; therefore we have to put in a back pointer. > + */ > + void *priv; > + struct rb_node node; > +};
s/its/it's
> +/** > + * latch_tree_erase() - removes @nodes from the trees @root > + * @nodes: nodes to remote > + * @root: trees to remove @nodes from > + * @ops: operators defining the node order > + * > + * Removes @nodes from the trees @root in an ordered fashion such that we can > + * always observe one complete tree. See the comment for > + * raw_write_seqcount_latch(). > + * > + * It is assumed that @nodes will observe one RCU quiesent state before being > + * reused of freed.
s/quiesent/quiescent
Thanks,
Ingo
| |