Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 18 Mar 2015 14:44:25 +0100 | From | Vlastimil Babka <> | Subject | Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock_migratetype() |
| |
On 03/11/2015 07:08 PM, Fabian Frederick wrote: > mt is already declared above and global value not used after loop. > This fixes a shadow warning. > > Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 1b84950..4ec8c23 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1653,7 +1653,7 @@ int __isolate_free_page(struct page *page, unsigned int order) > if (order >= pageblock_order - 1) { > struct page *endpage = page + (1 << order) - 1; > for (; page < endpage; page += pageblock_nr_pages) { > - int mt = get_pageblock_migratetype(page); > + mt = get_pageblock_migratetype(page); > if (!is_migrate_isolate(mt) && !is_migrate_cma(mt)) > set_pageblock_migratetype(page, > MIGRATE_MOVABLE); >
| ![\](/images/icornerr.gif) |