Messages in this thread | | | Subject | Re: [PATCH v2] phy: Add a driver for dm816x USB PHY | From | Paul Bolle <> | Date | Wed, 18 Mar 2015 12:13:31 +0100 |
| |
Two trivialities I failed the spot the first time.
On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote: > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 2962de2..c858c2b 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig
> +config PHY_DM816X_USB > + tristate "TI dm816x USB PHY driver" > + depends on ARCH_OMAP2PLUS > + select GENERIC_PHY > + help > + Enable this for dm81xx USB to work." > +
A trailing double quote.
> --- /dev/null > +++ b/drivers/phy/phy-dm816x-usb.c
> +MODULE_ALIAS("platform: dm816x_usb");
That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or will it end up in the mdule, in modules.alias, and presumably break something (I'm not sure what, actually)?
There are currently six other instances MODULE_ALIAS() that have a space there. That would mean they're all broken, somehow, which would be unlikely, so I guess it's just a stylistic nit.
Paul Bolle
| |