lkml.org 
[lkml]   [2015]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 05/10] USB: f81232: implement MCR/MSR function
On Thu, Feb 26, 2015 at 06:02:11PM +0800, Peter Hung wrote:
> This patch implement relative MCR/MSR function, such like
> tiocmget()/tiocmset()/dtr_rts()/carrier_raised()
>
> original f81232_carrier_raised() compared with wrong value UART_DCD.
> It's should compared with UART_MSR_DCD.
>
> Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
> ---
> drivers/usb/serial/f81232.c | 139 +++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 117 insertions(+), 22 deletions(-)

> +static int f81232_set_mctrl(struct usb_serial_port *port,
> + unsigned int set, unsigned int clear)
> +{
> + u8 urb_value;

Minor nit: could you just call this "val" as it's unrelated to any urb.

Also looks good otherwise.

Johan


\
 
 \ /
  Last update: 2015-03-14 13:21    [W:2.654 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site