lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/7] nilfs2: do not use async write flag for segment summary buffers
    Date
    The async write flag is introduced to nilfs2 in the commit
    7f42ec394156 ("nilfs2: fix issue with race condition of competition
    between segments for dirty blocks"), but the flag only makes sense for
    data buffers and btree node buffers. It is not needed for segment
    summary buffers.

    This gits rid of the latter uses as part of refactoring of atomic bit
    operations on buffer state bitmap.

    Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
    ---
    fs/nilfs2/segment.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
    index 0c3f303..c9a4e60 100644
    --- a/fs/nilfs2/segment.c
    +++ b/fs/nilfs2/segment.c
    @@ -1588,7 +1588,6 @@ static void nilfs_segctor_prepare_write(struct nilfs_sc_info *sci)

    list_for_each_entry(bh, &segbuf->sb_segsum_buffers,
    b_assoc_buffers) {
    - set_buffer_async_write(bh);
    if (bh->b_page != bd_page) {
    if (bd_page) {
    lock_page(bd_page);
    @@ -1688,7 +1687,6 @@ static void nilfs_abort_logs(struct list_head *logs, int err)
    list_for_each_entry(segbuf, logs, sb_list) {
    list_for_each_entry(bh, &segbuf->sb_segsum_buffers,
    b_assoc_buffers) {
    - clear_buffer_async_write(bh);
    if (bh->b_page != bd_page) {
    if (bd_page)
    end_page_writeback(bd_page);
    @@ -1768,7 +1766,6 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci)
    b_assoc_buffers) {
    set_buffer_uptodate(bh);
    clear_buffer_dirty(bh);
    - clear_buffer_async_write(bh);
    if (bh->b_page != bd_page) {
    if (bd_page)
    end_page_writeback(bd_page);
    --
    1.8.3.1


    \
     
     \ /
      Last update: 2015-03-12 16:01    [W:4.190 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site