lkml.org 
[lkml]   [2015]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9] inode: rename i_wb_list to i_io_list
    Date
    From: Dave Chinner <dchinner@redhat.com>

    There's a small consistency problem between the inode and writeback
    naming. Writeback calls the "for IO" inode queues b_io and
    b_more_io, but the inode calls these the "writeback list" or
    i_wb_list. This makes it hard to an new "under writeback" list to
    the inode, or call it an "under IO" list on the bdi because either
    way we'll have writeback on IO and IO on writeback and it'll just be
    confusing. I'm getting confused just writing this!

    So, rename the inode "for IO" list variable to i_io_list so we can
    add a new "writeback list" in a subsequent patch.

    Signed-off-by: Dave Chinner <dchinner@redhat.com>
    Reviewed-by: Jan Kara <jack@suse.cz>
    ---
    fs/fs-writeback.c | 20 ++++++++++----------
    fs/inode.c | 6 +++---
    include/linux/fs.h | 2 +-
    mm/backing-dev.c | 8 ++++----
    4 files changed, 18 insertions(+), 18 deletions(-)

    diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
    index dcfe21c..cabebde 100644
    --- a/fs/fs-writeback.c
    +++ b/fs/fs-writeback.c
    @@ -84,7 +84,7 @@ EXPORT_SYMBOL_GPL(inode_to_bdi);

    static inline struct inode *wb_inode(struct list_head *head)
    {
    - return list_entry(head, struct inode, i_wb_list);
    + return list_entry(head, struct inode, i_io_list);
    }

    /*
    @@ -193,7 +193,7 @@ void inode_wb_list_del(struct inode *inode)
    struct backing_dev_info *bdi = inode_to_bdi(inode);

    spin_lock(&bdi->wb.list_lock);
    - list_del_init(&inode->i_wb_list);
    + list_del_init(&inode->i_io_list);
    spin_unlock(&bdi->wb.list_lock);
    }

    @@ -216,7 +216,7 @@ static void redirty_tail(struct inode *inode, struct bdi_writeback *wb)
    if (time_before(inode->dirtied_when, tail->dirtied_when))
    inode->dirtied_when = jiffies;
    }
    - list_move(&inode->i_wb_list, &wb->b_dirty);
    + list_move(&inode->i_io_list, &wb->b_dirty);
    }

    /*
    @@ -225,7 +225,7 @@ static void redirty_tail(struct inode *inode, struct bdi_writeback *wb)
    static void requeue_io(struct inode *inode, struct bdi_writeback *wb)
    {
    assert_spin_locked(&wb->list_lock);
    - list_move(&inode->i_wb_list, &wb->b_more_io);
    + list_move(&inode->i_io_list, &wb->b_more_io);
    }

    static void inode_sync_complete(struct inode *inode)
    @@ -284,7 +284,7 @@ static int move_expired_inodes(struct list_head *delaying_queue,
    if (older_than_this &&
    inode_dirtied_after(inode, *older_than_this))
    break;
    - list_move(&inode->i_wb_list, &tmp);
    + list_move(&inode->i_io_list, &tmp);
    moved++;
    if (flags & EXPIRE_DIRTY_ATIME)
    set_bit(__I_DIRTY_TIME_EXPIRED, &inode->i_state);
    @@ -307,7 +307,7 @@ static int move_expired_inodes(struct list_head *delaying_queue,
    list_for_each_prev_safe(pos, node, &tmp) {
    inode = wb_inode(pos);
    if (inode->i_sb == sb)
    - list_move(&inode->i_wb_list, dispatch_queue);
    + list_move(&inode->i_io_list, dispatch_queue);
    }
    }
    out:
    @@ -458,10 +458,10 @@ static void requeue_inode(struct inode *inode, struct bdi_writeback *wb,
    */
    redirty_tail(inode, wb);
    } else if (inode->i_state & I_DIRTY_TIME) {
    - list_move(&inode->i_wb_list, &wb->b_dirty_time);
    + list_move(&inode->i_io_list, &wb->b_dirty_time);
    } else {
    /* The inode is clean. Remove from writeback lists. */
    - list_del_init(&inode->i_wb_list);
    + list_del_init(&inode->i_io_list);
    }
    }

    @@ -598,7 +598,7 @@ writeback_single_inode(struct inode *inode, struct bdi_writeback *wb,
    * touch it. See comment above for explanation.
    */
    if (!(inode->i_state & I_DIRTY_ALL))
    - list_del_init(&inode->i_wb_list);
    + list_del_init(&inode->i_io_list);
    spin_unlock(&wb->list_lock);
    inode_sync_complete(inode);
    out:
    @@ -1272,7 +1272,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
    }

    inode->dirtied_when = jiffies;
    - list_move(&inode->i_wb_list, dirtytime ?
    + list_move(&inode->i_io_list, dirtytime ?
    &bdi->wb.b_dirty_time : &bdi->wb.b_dirty);
    spin_unlock(&bdi->wb.list_lock);
    trace_writeback_dirty_inode_enqueue(inode);
    diff --git a/fs/inode.c b/fs/inode.c
    index bd61843..e0f2a60 100644
    --- a/fs/inode.c
    +++ b/fs/inode.c
    @@ -31,7 +31,7 @@
    * inode->i_sb->s_inode_list_lock protects:
    * inode->i_sb->s_inodes, inode->i_sb_list
    * bdi->wb.list_lock protects:
    - * bdi->wb.b_{dirty,io,more_io,dirty_time}, inode->i_wb_list
    + * bdi->wb.b_{dirty,io,more_io,dirty_time}, inode->i_io_list
    * inode_hash_lock protects:
    * inode_hashtable, inode->i_hash
    *
    @@ -355,7 +355,7 @@ void inode_init_once(struct inode *inode)
    memset(inode, 0, sizeof(*inode));
    INIT_HLIST_NODE(&inode->i_hash);
    INIT_LIST_HEAD(&inode->i_devices);
    - INIT_LIST_HEAD(&inode->i_wb_list);
    + INIT_LIST_HEAD(&inode->i_io_list);
    INIT_LIST_HEAD(&inode->i_lru);
    address_space_init_once(&inode->i_data);
    i_size_ordered_init(inode);
    @@ -523,7 +523,7 @@ static void evict(struct inode *inode)
    BUG_ON(!(inode->i_state & I_FREEING));
    BUG_ON(!list_empty(&inode->i_lru));

    - if (!list_empty(&inode->i_wb_list))
    + if (!list_empty(&inode->i_io_list))
    inode_wb_list_del(inode);

    inode_sb_list_del(inode);
    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index 4418693..64b16e0 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -607,7 +607,7 @@ struct inode {
    unsigned long dirtied_when; /* jiffies of first dirtying */

    struct hlist_node i_hash;
    - struct list_head i_wb_list; /* backing dev IO list */
    + struct list_head i_io_list; /* backing dev IO list */
    struct list_head i_lru; /* inode LRU list */
    struct list_head i_sb_list;
    union {
    diff --git a/mm/backing-dev.c b/mm/backing-dev.c
    index 6dc4580..6e7a644 100644
    --- a/mm/backing-dev.c
    +++ b/mm/backing-dev.c
    @@ -54,13 +54,13 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)

    nr_dirty = nr_io = nr_more_io = nr_dirty_time = 0;
    spin_lock(&wb->list_lock);
    - list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
    + list_for_each_entry(inode, &wb->b_dirty, i_io_list)
    nr_dirty++;
    - list_for_each_entry(inode, &wb->b_io, i_wb_list)
    + list_for_each_entry(inode, &wb->b_io, i_io_list)
    nr_io++;
    - list_for_each_entry(inode, &wb->b_more_io, i_wb_list)
    + list_for_each_entry(inode, &wb->b_more_io, i_io_list)
    nr_more_io++;
    - list_for_each_entry(inode, &wb->b_dirty_time, i_wb_list)
    + list_for_each_entry(inode, &wb->b_dirty_time, i_io_list)
    if (inode->i_state & I_DIRTY_TIME)
    nr_dirty_time++;
    spin_unlock(&wb->list_lock);
    --
    1.9.3


    \
     
     \ /
      Last update: 2015-03-10 21:01    [W:9.205 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site