Messages in this thread | | | Date | Fri, 06 Feb 2015 09:07:10 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH 3/3] arm64: dts: Add dts files for Hisilicon Hi6220 SoC |
| |
On 06/02/15 08:42, Brent Wang wrote:
[...]
>> >>> + <0x0 0xf6802000 0x0 0x2000>, /* GICC */ >>> + <0x0 0xf6804000 0x0 0x2000>, /* GICH */ >>> + <0x0 0xf6806000 0x0 0x2000>; /* GICV */ >> >> I guess no-one's bothered to consider 64k pages? >> >> Given GICH and GICV, I hope that this platform is booted at EL2? > Transfer from EL3 to EL1 directly, keep these two just for future use.
That's a real shame, as it keeps users away from some key aspects of the ARMv8 architecture.
>> >>> + #interrupt-cells = <3>; >>> + #address-cells = <0>; >>> + interrupt-controller;
And if you're keeping GICH/GICV, where is the maintenance interrupt?
>>> + }; >>> + >>> + >>> + timer { >>> + compatible = "arm,armv8-timer"; >>> + interrupt-parent = <&gic>; >>> + interrupts = <1 13 0xff08>, >>> + <1 14 0xff08>, >>> + <1 11 0xff08>, >>> + <1 10 0xff08>; >>> + clock-frequency = <1200000>; >>> + }; >> >> NAK. Fix your firmware to configure CNTFRQ, on all CPUs. > Fix in next version, maybe it will take some time to change firmware.
While you're at it, make sure CNTVOFF_EL2 is set to zero on all CPUs before dropping to EL1. This tends to be overlooked.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |