Messages in this thread | | | Date | Thu, 5 Feb 2015 22:46:32 +0000 | From | Al Viro <> | Subject | Re: [RFC][PATCH 5/7] trace: make filter_parse_regex() provide the length of substring to compare with |
| |
On Thu, Feb 05, 2015 at 05:07:43PM -0500, Steven Rostedt wrote: > On Thu, 5 Feb 2015 21:44:24 +0000 > Al Viro <viro@ZenIV.linux.org.uk> wrote: > > > > The point is that by now this strlen() is the only thing for which we > > NUL-termination of the substring; moving it inside the filter_parse_regex() > > is an obviously equivalent transformation and it leaves that one strlen() call > > inside filter_parse_regex() the only place where we still care about NUL. > > > > The next commit kills it off completely, at which point we are done with > > modifying the string at all. > > Thanks for the explanation, > > Can you add that to the change log. I like to think patches can stand > on their own, and if they are added to help another patch, it should be > stated in the change log so someone doing a git blame followed by a git > show, knows what is going on.
Done and force-pushed. Do you want me to repost the whole thing?
| |