Messages in this thread | | | Date | Thu, 05 Feb 2015 15:13:08 -0700 | From | Shuah Khan <> | Subject | Re: [RFC][PATCH 0/7] Start adding timetests to selftest |
| |
On 02/04/2015 11:37 PM, John Stultz wrote: > I've maintained a suite of timekeeping and timer tests for awhile > here: https://github.com/johnstultz-work/timetests > > I've been meaning to get them reworked and submitted into the > selftest infrastructure, but haven't had much time recently. > > I'm going to have a long flight coming up so I figured I'd > get started and get some initial feedback. > > This series adds all the non-destructive tests from my > timetests suite. The suite has more tests which actually tweak > time state and validate things behave as expected, but I wasn't > sure how to integrate that into the selftest infrastructure > as I'm not sure everyone would want the tests to be mucking > with their system time. (Currently my plan is to add a > script similar to the runall.sh in timetests, so folks > can go in and manually run it if they're feeling daring)
Providing a way to run destructive tests as a special option is great. Non-destructive tests can be run in default mode.
Thanks for the tests. Looks good to me. I am in the middle of review at the moment, will send you comments if any.
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |