Messages in this thread | | | Date | Thu, 5 Feb 2015 13:28:22 -0800 | Subject | Re: [PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions | From | Kees Cook <> |
| |
On Thu, Feb 5, 2015 at 11:35 AM, Hari Bathini <hbathini@linux.vnet.ibm.com> wrote: > This patch series adds pstore support on powernv platform to > read different nvram partitions and write compressed data to > oops-log nvram partition. As pseries platform already has > pstore support, this series moves most of the common code > for pseries and powernv platforms to a common file. Tested > the patches successfully on both pseries and powernv > platforms. Also, tested the patches successfully, on a kernel > compiled with both CONFIG_PPC_PSERIES=y & CONFIG_PPC_POWERNV=y. > > Changes from v4: > 1. Added a patch for y2038-safe code changes > > --- > > Hari Bathini (4): > powerpc/nvram: move generic code for nvram and pstore > pstore: Add pstore type id for PPC64 opal nvram partition > pstore: add pstore support on powernv > powerpc: make timestamp related code y2038-safe
Thanks! I skimmed this, and it looks good to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> > > arch/powerpc/include/asm/nvram.h | 50 ++ > arch/powerpc/include/asm/rtas.h | 5 > arch/powerpc/kernel/nvram_64.c | 677 +++++++++++++++++++++++++++ > arch/powerpc/platforms/powernv/opal-nvram.c | 10 > arch/powerpc/platforms/pseries/nvram.c | 673 --------------------------- > fs/pstore/inode.c | 3 > include/linux/pstore.h | 1 > 7 files changed, 754 insertions(+), 665 deletions(-) > > -- > -Hari >
-- Kees Cook Chrome OS Security
| |