lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] uwb/whci: Delete an unnecessary check before the function call "umc_device_unregister"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 21:40:29 +0100

    The umc_device_unregister() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/uwb/whci.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/uwb/whci.c b/drivers/uwb/whci.c
    index 46b7cfc..c3ee39a 100644
    --- a/drivers/uwb/whci.c
    +++ b/drivers/uwb/whci.c
    @@ -133,8 +133,7 @@ static void whci_del_cap(struct whci_card *card, int n)
    {
    struct umc_dev *umc = card->devs[n];

    - if (umc != NULL)
    - umc_device_unregister(umc);
    + umc_device_unregister(umc);
    }

    static int whci_n_caps(struct pci_dev *pci)
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 22:01    [W:3.050 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site