lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Input: Delete an unnecessary check before the function call "input_free_device"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 17:35:35 +0100

    The input_free_device() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/input/joystick/adi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c
    index b784257..d09cefa 100644
    --- a/drivers/input/joystick/adi.c
    +++ b/drivers/input/joystick/adi.c
    @@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv)
    }
    }
    fail2: for (i = 0; i < 2; i++)
    - if (port->adi[i].dev)
    - input_free_device(port->adi[i].dev);
    + input_free_device(port->adi[i].dev);
    gameport_close(gameport);
    fail1: gameport_set_drvdata(gameport, NULL);
    kfree(port);
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 18:01    [W:4.021 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site