Messages in this thread | | | Date | Thu, 5 Feb 2015 17:40:12 +0100 | From | Nicolas Ferre <> | Subject | Re: [PATCH v2] net/macb: fix sparse warning |
| |
Le 05/02/2015 17:21, Lad Prabhakar a écrit : > From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> > > this patch fixes following sparse warning: > > macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? > > Alongside drops exporting of gem_ethtool_ops as there is no need. > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Okay with this one: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks! Bye,
> --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/net/ethernet/cadence/macb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 4f7bd13..ad76b8e 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2035,7 +2035,7 @@ const struct ethtool_ops macb_ethtool_ops = { > }; > EXPORT_SYMBOL_GPL(macb_ethtool_ops); > > -const struct ethtool_ops gem_ethtool_ops = { > +static const struct ethtool_ops gem_ethtool_ops = { > .get_settings = macb_get_settings, > .set_settings = macb_set_settings, > .get_regs_len = macb_get_regs_len, > @@ -2046,7 +2046,6 @@ const struct ethtool_ops gem_ethtool_ops = { > .get_strings = gem_get_ethtool_strings, > .get_sset_count = gem_get_sset_count, > }; > -EXPORT_SYMBOL_GPL(gem_ethtool_ops); > > int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > { >
-- Nicolas Ferre
| |