lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [v3,1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain
From
Hi Pankaj and Sylwester,

On Thu, Feb 5, 2015 at 6:56 PM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> On 05/02/15 08:44, Pankaj Dubey wrote:
>>> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = {
>
>>> > +
>>> > + /* ENABLE_PCLK_APOLLO */
>>> > + GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo",
>>> > + "div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO,
>>> > + 2, CLK_IGNORE_UNUSED, 0),
>>> > + GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo",
>>> > + ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0),
>>> > + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo",
>>
>> Isn't "pclk_pmu_sysreg_apollo" be named as "pclk_sysreg_apollo" to match
>> with UM?

You're right. It is my mistake.
>
> Sounds reasonable, Chanwoo, if you agree I'll squash following change
> to this patch before sending upstream:

I agree.

>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c
> b/drivers/clk/samsung/clk-exynos5433.c
> index 7a024cd..387e3e3 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -3656,7 +3656,7 @@ static struct samsung_gate_clock apollo_gate_clks[]
> __initdata = {
> 2, CLK_IGNORE_UNUSED, 0),
> GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo",
> ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0),
> - GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo",
> + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_sysreg_apollo",
> "div_pclk_apollo", ENABLE_PCLK_APOLLO,
> 0, CLK_IGNORE_UNUSED, 0),

Best Regards,
Chanwoo Choi


\
 
 \ /
  Last update: 2015-02-05 15:01    [W:0.069 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site