Messages in this thread | | | Date | Thu, 5 Feb 2015 16:41:14 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] au1100fb: Delete unnecessary checks before two function calls |
| |
On Thu, Feb 05, 2015 at 02:14:54PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 5 Feb 2015 14:10:21 +0100 > > The functions clk_enable() and clk_disable() test whether their argument > is NULL and then return immediately.
This isn't true for clk_enable().
"I find it acceptable that some of my update suggestions do not fit to your quality expectations at the moment." -- https://lkml.org/lkml/2015/1/22/446
It's frustrating that you make the same mistake over and over and you are fine with doing that. If you make a mistake and you are fixing a bug, then hopefully you fix more bugs than you introduce. If you make a mistake and you are doing a cleanup then you are really just introducing bugs and that's not helpful. I wish you would find something useful to do instead of sending these patches. :(
regards, dan carpenter
| |