lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling
From
Date

On Wed, 2015-02-04 at 16:59 +0000, Jonathan Cameron wrote:
> On 02/02/15 08:37, Nicholas Mc Guire wrote:
> > This patch fixes two issues:
> > * return type of wait_for_completion_timeout is unsigned long not int,
> > rather than adding a dedicated variable the wait_for_completion_timeout
> > is moved into the condition directly
> > * the timeout of wait_for_completion_timeout is in jiffies but the value
> > being passed was a unsigned long not converted to jiffies and thus was
> > dependent on the HZ settings which is probably not what you want.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Ivan, need your Ack / Reviewed-by on this one.
>

Yes, change is correct, as explained before [1].

Acked-by: Ivan T. Ivanov <iivanov@mm-sol.com>


[1] https://lkml.org/lkml/2015/1/5/409



\
 
 \ /
  Last update: 2015-02-05 14:01    [W:0.039 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site