Messages in this thread | | | Subject | Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling | From | "Ivan T. Ivanov" <> | Date | Thu, 05 Feb 2015 14:23:11 +0200 |
| |
On Wed, 2015-02-04 at 16:59 +0000, Jonathan Cameron wrote: > On 02/02/15 08:37, Nicholas Mc Guire wrote: > > This patch fixes two issues: > > * return type of wait_for_completion_timeout is unsigned long not int, > > rather than adding a dedicated variable the wait_for_completion_timeout > > is moved into the condition directly > > * the timeout of wait_for_completion_timeout is in jiffies but the value > > being passed was a unsigned long not converted to jiffies and thus was > > dependent on the HZ settings which is probably not what you want. > > > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > Ivan, need your Ack / Reviewed-by on this one. >
Yes, change is correct, as explained before [1].
Acked-by: Ivan T. Ivanov <iivanov@mm-sol.com>
[1] https://lkml.org/lkml/2015/1/5/409
| |