lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] driver core: Delete an unnecessary check before the function call "put_device"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 11:48:26 +0100

    The put_device() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/base/core.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/base/core.c b/drivers/base/core.c
    index 97e2baf..9c6536f 100644
    --- a/drivers/base/core.c
    +++ b/drivers/base/core.c
    @@ -1095,8 +1095,7 @@ done:
    kobject_del(&dev->kobj);
    Error:
    cleanup_device_parent(dev);
    - if (parent)
    - put_device(parent);
    + put_device(parent);
    name_error:
    kfree(dev->p);
    dev->p = NULL;
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 12:21    [W:4.024 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site