lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] GPU-DRM-Tegra: Delete an unnecessary check before the function call "vunmap"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Feb 2015 10:12:51 +0100

    The vunmap() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/tegra/fb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
    index e9c715d..803598e 100644
    --- a/drivers/gpu/drm/tegra/fb.c
    +++ b/drivers/gpu/drm/tegra/fb.c
    @@ -66,7 +66,7 @@ static void tegra_fb_destroy(struct drm_framebuffer *framebuffer)
    struct tegra_bo *bo = fb->planes[i];

    if (bo) {
    - if (bo->pages && bo->vaddr)
    + if (bo->pages)
    vunmap(bo->vaddr);

    drm_gem_object_unreference_unlocked(&bo->gem);
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-05 10:41    [W:4.026 / U:0.756 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site