Messages in this thread | | | Date | Tue, 3 Feb 2015 23:23:35 +0100 | Subject | Re: [PATCH] mtd: denali: Disable sub-page writes in Denali NAND driver | From | Richard Weinberger <> |
| |
On Tue, Feb 3, 2015 at 11:15 PM, Dinh Nguyen <dinh.linux@gmail.com> wrote: > Hi Brian, > > On Wed, Jan 14, 2015 at 9:38 AM, <dinguyen@opensource.altera.com> wrote: >> From: Graham Moore <grmoore@opensource.altera.com> >> >> The Denali Controller IP does not support sub-page writes. >> >> Signed-off-by: Graham Moore <grmoore@opensource.altera.com> >> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com> >> --- >> drivers/mtd/nand/denali.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c >> index b3b7ca1..b16b040 100644 >> --- a/drivers/mtd/nand/denali.c >> +++ b/drivers/mtd/nand/denali.c >> @@ -1565,6 +1565,9 @@ int denali_init(struct denali_nand_info *denali) >> denali->nand.options |= NAND_SKIP_BBTSCAN; >> denali->nand.ecc.mode = NAND_ECC_HW_SYNDROME; >> >> + /* no subpage writes on denali */ >> + denali->nand.options |= NAND_NO_SUBPAGE_WRITE; >> + >> /* >> * Denali Controller only support 15bit and 8bit ECC in MRST, >> * so just let controller do 15bit ECC for MLC and 8bit ECC for >> -- >> 2.2.1 >> > > Was wondering if you got a chance to look at this patch?
So this driver never worked? If it worked for some users we have to make sure that your change does not break existing setups. /me thinks of UBI.
-- Thanks, //richard
| |