lkml.org 
[lkml]   [2015]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure
On Tue, Feb 03, 2015 at 09:54:41AM +0800, Junjie Mao wrote:

Commit message here please.

> Signed-off-by: Junjie Mao <junjie.mao@hotmail.com>
> ---
> drivers/edac/edac_mc_sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> index 8e48d32efe37..ab2963bdd0d5 100644
> --- a/drivers/edac/edac_mc_sysfs.c
> +++ b/drivers/edac/edac_mc_sysfs.c
> @@ -1068,6 +1068,8 @@ fail_unregister_dimm:
> continue;
> device_unregister(&dimm->dev);
> }
> + if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate)
> + device_remove_file(&mci->dev, &dev_attr_sdram_scrub_rate);
> fail_unregister_dev:
> device_unregister(&mci->dev);
> fail_unregister_bus:

Do I see it correctly that the destroy path
edac_remove_sysfs_mci_device() doesn't call device_remove_file() on that
sysfs node either?

Please add that code too.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--


\
 
 \ /
  Last update: 2015-02-03 19:01    [W:0.308 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site