Messages in this thread | | | Date | Tue, 3 Feb 2015 18:34:13 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu/amd: Fix amd_iommu_free_device() |
| |
Hi Peter,
On Tue, Feb 03, 2015 at 01:25:51PM +0100, Peter Zijlstra wrote: > Subject: iommu/amd: Fix amd_iommu_free_device() > > put_device_state_wait() doesn't loop on the condition and a spurious > wakeup will have it free the device state even though there might still > be references out to it.
Hmm, have you seen spurious wakeups happening? The wakeup only comes from put_device_state() and only when the reference count goes to zero. From my understanding this should be correct, but maybe I got the API wrong.
Joerg
| |