lkml.org 
[lkml]   [2015]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] Input: bcm-keypad: add device tree bindings
    Hi Scott,

    On Thu, Feb 26, 2015 at 08:08:48AM -0800, Scott Branden wrote:
    > Documents the Broadcom keypad controller device tree bindings.
    >
    > Reviewed-by: Ray Jui <rjui@broadcom.com>
    > Signed-off-by: Scott Branden <sbranden@broadcom.com>
    > ---
    > .../devicetree/bindings/input/brcm,bcm-keypad.txt | 108 +++++++++++++++++++++
    > 1 file changed, 108 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/input/brcm,bcm-keypad.txt
    >
    > diff --git a/Documentation/devicetree/bindings/input/brcm,bcm-keypad.txt b/Documentation/devicetree/bindings/input/brcm,bcm-keypad.txt
    > new file mode 100644
    > index 0000000..e16bb2d
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/input/brcm,bcm-keypad.txt
    > @@ -0,0 +1,108 @@
    > +* Broadcom Keypad Controller device tree bindings
    > +
    > +Broadcom Keypad controller is used to interface a SoC with a matrix-type
    > +keypad device. The keypad controller supports multiple row and column lines.
    > +A key can be placed at each intersection of a unique row and a unique column.
    > +The keypad controller can sense a key-press and key-release and report the
    > +event using a interrupt to the cpu.
    > +
    > +This binding is based on the matrix-keymap binding with the following
    > +changes:
    > +
    > +keypad,num-rows and keypad,num-columns are required.
    > +
    > +Required SoC Specific Properties:
    > +- compatible: should be "brcm,bcm-keypad"
    > +
    > +- reg: physical base address of the controller and length of memory mapped
    > + region.
    > +
    > +- interrupts: The interrupt number to the cpu.
    > +
    > +Board Specific Properties:
    > +- keypad,num-rows: Number of row lines connected to the keypad
    > + controller.
    > +
    > +- keypad,num-columns: Number of column lines connected to the
    > + keypad controller.
    > +
    > +- col-debounce-filter-period: The debounce period for the Column filter.
    > +
    > + KEYPAD_DEBOUNCE_1_ms = 0
    > + KEYPAD_DEBOUNCE_2_ms = 1
    > + KEYPAD_DEBOUNCE_4_ms = 2
    > + KEYPAD_DEBOUNCE_8_ms = 3
    > + KEYPAD_DEBOUNCE_16_ms = 4
    > + KEYPAD_DEBOUNCE_32_ms = 5
    > + KEYPAD_DEBOUNCE_64_ms = 6
    > + KEYPAD_DEBOUNCE_128_ms = 7
    > +
    > +- status-debounce-filter-period: The debounce period for the Status filter.
    > +
    > + KEYPAD_DEBOUNCE_1_ms = 0
    > + KEYPAD_DEBOUNCE_2_ms = 1
    > + KEYPAD_DEBOUNCE_4_ms = 2
    > + KEYPAD_DEBOUNCE_8_ms = 3
    > + KEYPAD_DEBOUNCE_16_ms = 4
    > + KEYPAD_DEBOUNCE_32_ms = 5
    > + KEYPAD_DEBOUNCE_64_ms = 6
    > + KEYPAD_DEBOUNCE_128_ms = 7
    > +
    > +- row-output-enabled: An optional property indicating whether the row or
    > + column is being used as output. If specified the row is being used
    > + as the output. Else defaults to column.
    > +
    > +- pull-up-enabled: An optional property indicating the Keypad scan mode.
    > + If specified implies the keypad scan pull-up has been enabled.
    > +
    > +- linux,keypad-no-autorepeat: An optional property indicating to
    > + not enable autorepeat feature.

    Unfortunately we've accumulated a lot of bindings for turning autorepeat
    on or off, I would prefer if we standardize on what gpio-keys is doing
    and use "autorepeat" (no "linux,") for new drivers.

    Thanks.

    --
    Dmitry


    \
     
     \ /
      Last update: 2015-02-28 01:01    [W:3.556 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site